Skip to content

Add TypeScript definitions for store (fixes #1207) #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2018
Merged

Conversation

PaulBGD
Copy link
Member

@PaulBGD PaulBGD commented Mar 5, 2018

I'm not sure how to handle this for both the store.js and store.umd.js. I think in most cases TypeScript users will use store.js anyways, so I don't think it's a big issue.

@codecov-io
Copy link

codecov-io commented Mar 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@5f51856). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1208   +/-   ##
=========================================
  Coverage          ?   91.64%           
=========================================
  Files             ?      127           
  Lines             ?     4558           
  Branches          ?     1503           
=========================================
  Hits              ?     4177           
  Misses            ?      159           
  Partials          ?      222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f51856...59d67f0. Read the comment docs.

@PaulBGD
Copy link
Member Author

PaulBGD commented Mar 7, 2018

Remind me to not write definitions at night, I'll look at your suggestions in the morning.

@Kiho
Copy link
Contributor

Kiho commented Mar 10, 2018

I could not find official type definitions for svelte anywhere, can anybody give me a reference?

@stalkerg
Copy link
Contributor

@PaulBGD any update?

@Rich-Harris
Copy link
Member

finally got round to updating this

@Rich-Harris Rich-Harris merged commit d1f35df into master Oct 27, 2018
@Rich-Harris Rich-Harris deleted the gh-1207 branch October 27, 2018 20:57
7nik pushed a commit to 7nik/svelte that referenced this pull request Apr 9, 2025
sync svelte docs

Co-authored-by: svelte-docs-bot[bot] <196124396+svelte-docs-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants