Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent a11y_label_has_associated_control false positive for component in <label> #12119

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

wackbyte
Copy link
Contributor

Closes #12002.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: d4f427c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wackbyte
Copy link
Contributor Author

Should I go ahead and fix #11711 as well?

@paoloricciuti
Copy link
Member

I'll quote myself but i don't think that we should prevent this warnings: if you really know that inside the component there's an input you can always mute the warning yourself. Overfiring is better than overfiring for everything related to warnings

#12002 (comment)

@Rich-Harris
Copy link
Member

Thank you! I extended the fix to {@render ...} as well since it's straightforward.

As to whether this is desirable or not: I thought we were already applying similar logic elsewhere (i.e. skip warnings about what is required where if a component is involved) but I can't actually find any examples of it. So despite approving it just now I'm no longer 100% sure if this is the right move. I think I'm still in favour (too many false positive warnings are annoying and introduce warning fatigue) but would be interested to hear other people's thoughts on the matter.

@Rich-Harris
Copy link
Member

Though thinking about it more: we're already skipping the warning in the case of <slot> or <svelte:element>, so this is making things more consistent with a prior decision. This makes me more strongly in favour

@Rich-Harris Rich-Harris merged commit 5b60a0e into sveltejs:main Jun 21, 2024
7 of 9 checks passed
@wackbyte wackbyte deleted the a11y-label-component-control branch June 21, 2024 22:34
FoHoOV pushed a commit to FoHoOV/svelte that referenced this pull request Jun 27, 2024
…omponent in `<label>` (sveltejs#12119)

* fix: prevent `a11y_label_has_associated_control` false positive for component in `<label>`

* fix render tags as well

* Update .changeset/swift-rats-sing.md

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive a11y warning for label with control inside component
3 participants