-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent a11y_label_has_associated_control
false positive for component in <label>
#12119
fix: prevent a11y_label_has_associated_control
false positive for component in <label>
#12119
Conversation
…omponent in `<label>`
🦋 Changeset detectedLatest commit: d4f427c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Should I go ahead and fix #11711 as well? |
I'll quote myself but i don't think that we should prevent this warnings: if you really know that inside the component there's an input you can always mute the warning yourself. Overfiring is better than overfiring for everything related to warnings |
Thank you! I extended the fix to As to whether this is desirable or not: I thought we were already applying similar logic elsewhere (i.e. skip warnings about what is required where if a component is involved) but I can't actually find any examples of it. So despite approving it just now I'm no longer 100% sure if this is the right move. I think I'm still in favour (too many false positive warnings are annoying and introduce warning fatigue) but would be interested to hear other people's thoughts on the matter. |
Though thinking about it more: we're already skipping the warning in the case of |
…omponent in `<label>` (sveltejs#12119) * fix: prevent `a11y_label_has_associated_control` false positive for component in `<label>` * fix render tags as well * Update .changeset/swift-rats-sing.md --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>
Closes #12002.
Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint