Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent (and slightly embarrassing) revelation — we are currently exposing our private junk in addition to all our public interfaces. It turns out that these are not the same:
In the first case, for reasons I cannot begin to fathom, TypeScript exposes everything, not just the things that were explicitly marked with the
export
keyword. In the second case, sanity prevails.dts-buddy
, which generates our bundle of types, was recently fixed to always use the second form. This is technically a breaking change insofar as someone might have depended on a 'private' (and undocumented) type.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint