Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve type arguments for Snippet and $bindable #12197

Merged
merged 4 commits into from
Jun 29, 2024

Conversation

NotWoods
Copy link
Contributor

When looking at the type for Snippet (for example, using Go to Type Definition in VSCode) it's difficult to tell what generics to pass. I replaced the vauge T name with Arguments and added some JSDoc. I also fixed the sample code for Snippet to use a tuple.

Additional small change in the same vein: rename t in $bindable to fallback in the types

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: e02b505

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Thank you! Can you run pnpm generate:types from packages/svelte and commit the change? Then we're good to go

@Rich-Harris Rich-Harris merged commit 72fec99 into sveltejs:main Jun 29, 2024
7 of 9 checks passed
@Rich-Harris
Copy link
Member

thank you!

@NotWoods NotWoods deleted the snippet-type branch June 30, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants