Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly validate <svelte:component> with bind:this #12368

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Rich-Harris
Copy link
Member

We need to return the instance from bind_this otherwise validate_dynamic_component will get mad. No test because we use the legacy component API in the tests, meaning it doesn't fail in the first place

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 7b4b265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

going to merge this, since it's blocking me from running the site locally

@Rich-Harris Rich-Harris merged commit 1d8d38c into main Jul 9, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the fix-dynamic-component-bind-this branch July 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant