Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more robust handling of var declarations #12949

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix: more robust handling of var declarations #12949

merged 2 commits into from
Aug 21, 2024

Conversation

dummdidumm
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

- fixes #12807: state declared with var is now retrieved using a new `safe_get` function, which works like `get` but checks for undefined
- fixes #12900: ensure we're not creating another new scope for block statements of function declarations, which resulted in var declarations getting "swallowed" (because they were hoisted to the function declaration scope and never seen by our logic)
Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 77c528c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Aug 21, 2024

I actually love the simplicity of this for var vs the amount of work required to handle the oddities the other way.

@dummdidumm
Copy link
Member Author

dummdidumm commented Aug 21, 2024

yeah adding a new hoisting mechanism to the state, which is tied to the nearest scope etc etc felt way to involved for this. Also, it wouldn't stop there, you'd have to hoist and then update the signal in a special way.

console.log(x);
var x = $state(..);
// -->
var x = $.source();
console.log($.get(x));
x.v = ...;

All that additional code for such a niche thing doesn't feel worth the additional overhead, which is why I went with this solution.

@Rich-Harris Rich-Harris merged commit 01d32e5 into main Aug 21, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the var-fixes branch August 21, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: $state declared with var in *.svelte.js broken Svelte 5: using var with $state is brittle
3 participants