Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove buggy validate_dynamic_component check #12960

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Rich-Harris
Copy link
Member

Alternative to #12950, closes #12857.

In other contexts, we've decided that it makes more sense to rely on typechecking than to insert runtime checks everywhere:

image

I think that goes double when the validation itself is brittle and inconsistently applied (for <svelte:component>, but not for a normal <Component> that's dynamic). We can make our lives simpler here.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 7865d38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

👍 I like this solution.

@dummdidumm dummdidumm merged commit 8c1d439 into main Aug 21, 2024
9 checks passed
@dummdidumm dummdidumm deleted the remove-validate-dynamic-component branch August 21, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: svelte_component_invalid_this_value has false positives
3 participants