-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: repo cleanup #13029
chore: repo cleanup #13029
Conversation
- remove prettier from packages, everything runs through the root now (also better aligns with how you work with it in VS Code: no more config duplication needed) - remove eslint from packages, run it once through the root now (revealed some inconsistencies and missing stuff, config tightened up as a result) (bump eslint while we're at it)
…o one estree node we need to adjust code a bit)
|
Not being able to run prettier and eslint on just the Svelte project has been driving me crazy for two reasons:
Is this something we could revisit? I'm also curious what your workflow is like and if there's something more efficient I should be doing. Does prettier work in VS Code now and not before? I've never had it doing anything, but if this fixes it then maybe I don't need to run it on the CLI anymore |
I have the monorepo open at the root. prettier then only picks up the |
Housekeeping PR, mainly bumping packages (closes #12224)
skipLibCheck
because it would mean our ownd.ts
files aren't checked anymore. Instead bump a few packages and move deps around to get rid of the error for which it was introduced@rollup/plugin-commonjs
which introduces a bunch of new deps and otherwise has no observable changes for us) or the corresponding project (likesvelte.dev
) will be overhauled soon, anywayBefore submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint