Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: repo cleanup #13029

Merged
merged 5 commits into from
Aug 26, 2024
Merged

chore: repo cleanup #13029

merged 5 commits into from
Aug 26, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Aug 26, 2024

Housekeeping PR, mainly bumping packages (closes #12224)

  • remove skipLibCheck because it would mean our own d.ts files aren't checked anymore. Instead bump a few packages and move deps around to get rid of the error for which it was introduced
  • remove prettier from packages, everything runs through the root now (also better aligns with how you work with it in VS Code: no more config duplication needed)
  • remove eslint from packages, run it once through the root now (revealed some inconsistencies and missing stuff, config tightened up as a result) (bump eslint while we're at it)
  • bump a few other packages. Those not bumped are either not worth it (like @rollup/plugin-commonjs which introduces a bunch of new deps and otherwise has no observable changes for us) or the corresponding project (like svelte.dev) will be overhauled soon, anyway
  • bumped JSOM which required adjusting a few tests

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

- remove prettier from packages, everything runs through the root now (also better aligns with how you work with it in VS Code: no more config duplication needed)
- remove eslint from packages, run it once through the root now (revealed some inconsistencies and missing stuff, config tightened up as a result) (bump eslint while we're at it)
…o one estree node we need to adjust code a bit)
Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: c646fbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit c4b7215 into main Aug 26, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the repo-cleanup branch August 26, 2024 15:30
@benmccann
Copy link
Member

remove prettier from packages, everything runs through the root now (also better aligns with how you work with it in VS Code: no more config duplication needed)
remove eslint from packages, run it once through the root now (revealed some inconsistencies and missing stuff, config tightened up as a result) (bump eslint while we're at it)

Not being able to run prettier and eslint on just the Svelte project has been driving me crazy for two reasons:

  • I have to keep switching back and forth between packages/svelte and the root in my terminal since I can only run the command from root now
  • I have to wait for them to run over lots of unrelated things like the docs

Is this something we could revisit? I'm also curious what your workflow is like and if there's something more efficient I should be doing. Does prettier work in VS Code now and not before? I've never had it doing anything, but if this fixes it then maybe I don't need to run it on the CLI anymore

@dummdidumm
Copy link
Member Author

dummdidumm commented Sep 6, 2024

I have the monorepo open at the root. prettier then only picks up the .prettierrc at the root, which is why they had to be duplicated before. I don't run eslint much and prettier will auto-format on save so I have no problems with running these scripts from the root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump all dependencies before final release
3 participants