-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: a11y warning for <button>
/ <a>
without aria-label and content
#13130
feat: a11y warning for <button>
/ <a>
without aria-label and content
#13130
Conversation
🦋 Changeset detectedLatest commit: 9d9aef2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks but the recommendation is to have an |
371887e
to
8651d22
Compare
<button>
/ <a>
without aria-label<button>
/ <a>
without aria-label and content
packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y.js
Outdated
Show resolved
Hide resolved
Thanks @Rich-Harris! I've updated it to cover this. I've also made a small tweak to ignore elements if they contain |
8651d22
to
032dd0a
Compare
thanks! |
You guys are awesome! |
Attempting to address issue #12041 🙏
Introduce a11y warning for
<button>
/<a>
elements that are missing an aria-label and content:Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint