Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: a11y warning for <button> / <a> without aria-label and content #13130

Merged

Conversation

JR-G
Copy link
Contributor

@JR-G JR-G commented Sep 4, 2024

Attempting to address issue #12041 🙏

Introduce a11y warning for <button>/<a> elements that are missing an aria-label and content:

image

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 9d9aef2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Thanks but the recommendation is to have an aria-label if there's no content, not on every button/a element. Can you update the PR so that it only covers empty elements?

@JR-G JR-G force-pushed the issue-12041-button-accessibility-warnings branch from 371887e to 8651d22 Compare September 4, 2024 20:55
@JR-G JR-G changed the title feat: a11y warning for <button> / <a> without aria-label feat: a11y warning for <button> / <a> without aria-label and content Sep 4, 2024
@JR-G
Copy link
Contributor Author

JR-G commented Sep 4, 2024

Thanks but the recommendation is to have an aria-label if there's no content, not on every button/a element. Can you update the PR so that it only covers empty elements?

Thanks @Rich-Harris! I've updated it to cover this. I've also made a small tweak to ignore elements if they contain aria-hidden=true.

@Rich-Harris Rich-Harris merged commit c229e0f into sveltejs:main Sep 17, 2024
7 of 9 checks passed
@Rich-Harris
Copy link
Member

thanks!

@elron
Copy link

elron commented Sep 22, 2024

You guys are awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants