Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixes relating to bind:files & note on FileList API #13235

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

brunnerh
Copy link
Member

Relates to #13156, applies corrections regarding #13230.

If you try to construct a FileList you get this, because sometimes the DOM APIs are just 🔥:

Uncaught TypeError: Illegal constructor

If this is too much stuff/the example should go elsewhere, I'm happy to revise this as necessary.

(Tried linting, but it's kinda broken for me.)

Output
Oops! Something went wrong! :(

ESLint: 9.9.1

Error: Cannot find module 'E:\dev\svelte\node_modules\.pnpm\svelte-eslint-parser@0.41.0_svelte@packages+svelte\node_modules\svelte\compiler\index.js'
    at createEsmNotFoundErr (node:internal/modules/cjs/loader:1171:15)
    at finalizeEsmResolution (node:internal/modules/cjs/loader:1159:15)
    at resolveExports (node:internal/modules/cjs/loader:584:14)
    at Module._findPath (node:internal/modules/cjs/loader:658:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1120:27)
    at Module._load (node:internal/modules/cjs/loader:975:27)
    at Module.require (node:internal/modules/cjs/loader:1225:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (E:\dev\svelte\node_modules\.pnpm\svelte-eslint-parser@0.41.0_svelte@packages+svelte\node_modules\svelte-eslint-parser\lib\parser\template.js:4:20)
    at Module._compile (node:internal/modules/cjs/loader:1356:14)

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: 6efe3ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brunnerh
Copy link
Member Author

(Prettier doesn't do anything locally, yet the CI complains. Might be a platform related issue. In any case, at this point this piece of garbage is really wasting my time...)

@trueadm
Copy link
Contributor

trueadm commented Sep 13, 2024

Tried running pnpm format locally?

@brunnerh
Copy link
Member Author

Just did to be sure:

documentation/docs/02-template-syntax/08-bindings.md 46ms (unchanged)

@brunnerh
Copy link
Member Author

brunnerh commented Sep 13, 2024

Guess it did not like how I formatted the code, so now that it's gone linting passed.

@brunnerh brunnerh changed the title docs: fixes relating to bind:files & another example docs: fixes relating to bind:files & note on FileList API Sep 13, 2024
@brunnerh brunnerh requested a review from dummdidumm September 16, 2024 06:58
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 9204d69 into sveltejs:main Sep 16, 2024
7 of 9 checks passed
@brunnerh brunnerh deleted the bind-files-fixes branch September 16, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants