-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only warn on context="module" in runes mode #13332
Conversation
🦋 Changeset detectedLatest commit: 7bd9320 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Does that mean we shouldn't be using `<script context="module"> anymore for storing svelte component related data that might be imported by other components? Is there a discussion on this I can read? |
It is now just |
I just tried this, however I get a warning if I do this: <script module lang="ts">
export const foo = 'foo';
</script>
<script lang="ts">
let bar = $state('bar');
const { gravy } = $props();
</script>
I get a warning if I do this: <script module lang="ts">
export const foo = 'foo';
let bar = $state('bar');
const { gravy } = $props();
</script>
|
Make sure you're on the latest version |
@dummdidumm I'm on Anyway thanks for the comments all resolved 🙏 |
we decided to only deprecate
<script context="module">
in runes mode, as it causes noisy warnings for certain librariesBefore submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint