chore: refactor RegularElement
visitor
#13350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precursor to #13270. We need to change how we deal with the combination of attributes and class/style directives, and ideally unify how attributes are handled between
RegularElement
andSvelteElement
. A first step towards that is moving the special case logic (for specific elements like<img>
or<input>
or whatever) out of the loop in which we separate attributes out into their different types.This PR just tries to make the logic a bit less entangled, and a bit easier to follow, with fewer variables declared far from their usage sites etc.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint