Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor RegularElement visitor #13350

Merged
merged 16 commits into from
Sep 20, 2024
Merged

chore: refactor RegularElement visitor #13350

merged 16 commits into from
Sep 20, 2024

Conversation

Rich-Harris
Copy link
Member

This is a precursor to #13270. We need to change how we deal with the combination of attributes and class/style directives, and ideally unify how attributes are handled between RegularElement and SvelteElement. A first step towards that is moving the special case logic (for specific elements like <img> or <input> or whatever) out of the loop in which we separate attributes out into their different types.

This PR just tries to make the logic a bit less entangled, and a bit easier to follow, with fewer variables declared far from their usage sites etc.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: dd10090

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants