-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor RegularElement
visitor
#13350
Conversation
|
This is a precursor to #13270. We need to change how we deal with the combination of attributes and class/style directives, and ideally unify how attributes are handled between
RegularElement
andSvelteElement
. A first step towards that is moving the special case logic (for specific elements like<img>
or<input>
or whatever) out of the loop in which we separate attributes out into their different types.This PR just tries to make the logic a bit less entangled, and a bit easier to follow, with fewer variables declared far from their usage sites etc.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint