Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use destructuring syntax for computed props in v2 mode - fixes #1069 #1345

Merged
merged 1 commit into from
Apr 15, 2018

Conversation

Rich-Harris
Copy link
Member

To prevent confusing ambiguity, this doesn't support props: state => state — that can wait for v2.

@codecov-io
Copy link

codecov-io commented Apr 15, 2018

Codecov Report

Merging #1345 into master will decrease coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
- Coverage   91.76%   91.69%   -0.07%     
==========================================
  Files         125      125              
  Lines        4515     4526      +11     
  Branches     1432     1435       +3     
==========================================
+ Hits         4143     4150       +7     
- Misses        149      151       +2     
- Partials      223      225       +2
Impacted Files Coverage Δ
src/generators/Generator.ts 96.7% <100%> (+0.01%) ⬆️
src/generators/dom/index.ts 95.8% <100%> (+0.05%) ⬆️
src/validate/index.ts 90% <100%> (+0.2%) ⬆️
src/validate/js/propValidators/computed.ts 87.5% <60%> (-12.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a99ce9...99ea753. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 6249fa6 into master Apr 15, 2018
@Rich-Harris Rich-Harris deleted the gh-1069 branch April 15, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants