-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: use <svelte-css-wrapper>
instead of <div>
for style props
#13499
Conversation
🦋 Changeset detectedLatest commit: b318f87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
What about <H1 --color="blue" /> or <Article --color="blue" /> where we will have heading or sectionning content inside a span (which has phrasing content model)? |
Yeah, we're going to have to use another element it seems. |
sounds like we need to use a bogus custom element like |
Actually hold on, it seems that |
<span>
instead of <div>
for style props<svelte-css-wrapper>
instead of <div>
for style props
The name feels a bit clunky, is there something shorter that could work? |
it could be a random name like |
The more characters the less chance of accidentally using an actual custom element. I'm not sure if aesthetics really matter here. |
The reason that this is a breaking change is that someone could (misguidedly) be using the existing |
Could it be called |
No that contains invalid element tag characters |
…div>` children Replaces the container `<div>` with a custom element which is similar to svelte changing to the `svelte-css-wrapper` (sveltejs/svelte#13499) custom element when injecting component style props.
Fixes #13490. This is a breaking change, so I've also documented the change too.