-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add migration-task
for impossible to migrate slots
#13658
Merged
paoloricciuti
merged 6 commits into
main
from
migration-task-for-impossible-to-migrate-slots
Oct 18, 2024
Merged
feat: add migration-task
for impossible to migrate slots
#13658
paoloricciuti
merged 6 commits into
main
from
migration-task-for-impossible-to-migrate-slots
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d7fa2e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think the TODO should be more useful, explain it has to be done by hand due to the slow being an invalid JS identifier |
paoloricciuti
commented
Oct 18, 2024
paoloricciuti
commented
Oct 18, 2024
packages/svelte/tests/migrate/samples/slot-non-identifier/output.svelte
Outdated
Show resolved
Hide resolved
paoloricciuti
commented
Oct 18, 2024
packages/svelte/tests/migrate/samples/slot-non-identifier/output.svelte
Outdated
Show resolved
Hide resolved
paoloricciuti
commented
Oct 18, 2024
packages/svelte/tests/migrate/samples/slot-non-identifier/output.svelte
Outdated
Show resolved
Hide resolved
paoloricciuti
commented
Oct 18, 2024
packages/svelte/tests/migrate/samples/slot-non-identifier/output.svelte
Outdated
Show resolved
Hide resolved
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
…ut.svelte Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
…ut.svelte Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
…ut.svelte Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
…ut.svelte Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
trueadm
approved these changes
Oct 18, 2024
paoloricciuti
deleted the
migration-task-for-impossible-to-migrate-slots
branch
October 18, 2024 01:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte 5 rewrite
Closes #13649
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint