-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor #1367
refactor #1367
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1367 +/- ##
==========================================
- Coverage 91.49% 91.11% -0.39%
==========================================
Files 126 120 -6
Lines 4469 4421 -48
Branches 1384 1360 -24
==========================================
- Hits 4089 4028 -61
- Misses 154 156 +2
- Partials 226 237 +11
Continue to review full report at Codecov.
|
At long last, the diff is now more red than green. Will probably find a few more things to tidy up but I reckon this is basically ready — going to remove the [WIP] label. Most apps should get slightly smaller as a result of this PR, due to the way context is kept up to date. |
@Conduitry ah, good catch, thanks |
See #1316.
Lots more work to do here, but I'm optimistic about the direction it's going in. Essentially the goals are:
contextualise
stuffI found myself leaning towards a couple of naming changes — internally,
generator
is referred to more simply ascompiler
, and in the generated code,state
becomesctx
, since it's more appropriate to speak of a 'context' once you're inside each/await blocks.