Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't print errors on migration errors #13754

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Oct 21, 2024

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: e480b35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Could you elaborate on the motivation behind this?

@paoloricciuti
Copy link
Member Author

Could you elaborate on the motivation behind this?

Yeah sorry I open the PR but I had to run lol

Scott pointed out that it's confusing to see the error in the console since there's already the log to point at the file. It could seem like the migration failed at all.

.changeset/large-carrots-behave.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit d1cac70 into main Oct 21, 2024
7 of 9 checks passed
@dummdidumm dummdidumm deleted the dont-print-errors-on-migration-errors branch October 21, 2024 19:06
@github-actions github-actions bot mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants