fix: show filename information in legacy_recursive_reactive_block
#13764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
As per discord discussion this add the name of the file the warning is generated from to
legacy_recursive_reactive_block
. The name is only available in dev but that's not a problem since the warning is only thrown inDEV
anyway. If for some reasonFILENAME
should not be there i've used "a file (we can't know which one)" as a fallback (not sure about the parenthesis tbf).Simon originally had the idea of passing the filename and position with via the ast but the run function is meant to be visible in the code so i think this approach is more than enough.
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint