Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show filename information in legacy_recursive_reactive_block #13764

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

paoloricciuti
Copy link
Member

Before submitting the PR, please make sure you do the following

As per discord discussion this add the name of the file the warning is generated from to legacy_recursive_reactive_block. The name is only available in dev but that's not a problem since the warning is only thrown in DEV anyway. If for some reason FILENAME should not be there i've used "a file (we can't know which one)" as a fallback (not sure about the parenthesis tbf).

Simon originally had the idea of passing the filename and position with via the ast but the run function is meant to be visible in the code so i think this approach is more than enough.

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 7e4de19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a changeset and we're good to merge

@paoloricciuti
Copy link
Member Author

Looks good, just needs a changeset and we're good to merge

Lol even when the title is good i mess the changeset

@dummdidumm dummdidumm merged commit 8ff2af5 into main Oct 21, 2024
9 checks passed
@dummdidumm dummdidumm deleted the show-name-in-legacy-recursive-reactive-block branch October 21, 2024 21:36
@github-actions github-actions bot mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants