Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internally wrap store subscribe in untrack #13858

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 24, 2024

Closes #13840. This issue keeps coming up time and time again. I think we can make the process of migration smoother by just internally wrapping the subscribe function in an untrack internally – which is what people would have had to have done in their functions anyway.

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 15f2342

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

This issue keeps coming up time and time again

Where-else did it come up?
FWIW I think it makes sense because of the start-stop-notifier logic.

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@trueadm
Copy link
Contributor Author

trueadm commented Oct 24, 2024

Where-else did it come up?

It's come up a bunch on Discord and there's been a discussion thread about this too. I guess it's quite common to do because like you say people probably use start-stop-notifier logic or some equivalent of it in their custom store logic.

@trueadm trueadm merged commit 60dcffb into main Oct 24, 2024
7 checks passed
@trueadm trueadm deleted the untrack-store-sub branch October 24, 2024 10:03
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: state_unsafe_mutation on trying to mix stores with runes
2 participants