Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip comment nodes in snippet validation logic #13936

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 25, 2024

Fixes #13865. We forgot to skip comment nodes in the validation logic.

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 01790fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 25, 2024

pnpm add https://pkg.pr.new/svelte@13936

commit: 01790fb

@trueadm trueadm merged commit 83a5eaa into main Oct 25, 2024
10 checks passed
@trueadm trueadm deleted the snippet-validation-comment branch October 25, 2024 21:04
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments are not allowed next to {#snippet children()}
2 participants