Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure video elements autoplay in safari #14095

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 1, 2024

Fixes #14087. It's safari specific, so I'm unable to create a unit test for this.

Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: 2485237

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 1, 2024

pnpm add https://pkg.pr.new/svelte@14095

commit: 2485237

@dummdidumm
Copy link
Member

Does adding the muted property as an attribute also work instead of importNode? We made it a property for Firefox, maybe for Safari it's the other way around, i.e. we need to set muted both as an attribute and as a property?

@trueadm
Copy link
Contributor Author

trueadm commented Nov 1, 2024

@dummdidumm That's the first thing I tried. It doesn't make any difference.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trueadm trueadm merged commit a315a14 into main Nov 1, 2024
10 checks passed
@trueadm trueadm deleted the video-autoplay-safari branch November 1, 2024 12:52
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Muted videos do not autoplay in Safari
2 participants