Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass along anchor in legacy class wrappers #14100

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

dummdidumm
Copy link
Member

fixes #13832

no test because it feels a bit silly for a legacy-one-liner

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: c2857e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 1, 2024

pnpm add https://pkg.pr.new/svelte@14100

commit: c2857e9

@dummdidumm dummdidumm merged commit e7d68d8 into main Nov 1, 2024
10 checks passed
@dummdidumm dummdidumm deleted the anchor-fix branch November 1, 2024 13:22
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: createClassComponent ignores anchor
2 participants