Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate multiple declarations with only some exported correctly #14126

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

paoloricciuti
Copy link
Member

Closes #14115

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

pkg-pr-new bot commented Nov 2, 2024

pnpm add https://pkg.pr.new/svelte@14126

commit: cd68739

@paoloricciuti paoloricciuti merged commit 74a2c6b into main Nov 3, 2024
10 checks passed
@paoloricciuti paoloricciuti deleted the migrate-export-let-multiple-declarations branch November 3, 2024 13:31
@github-actions github-actions bot mentioned this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte-5 migration breaks named exports
2 participants