Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure props passed to components via mount are updateable #14210

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 7, 2024

The detection whether or not props are writable is buggy; it doesn't take into account the case when instantiating components via mount or legacy-new

Fixes #14161

This posed an interesting question: What to do about (non-)bind:able properties? The answer I arrived on was: Treat it as if everything that can be bound is treated as bound, and everything else as readonly. In other words, if you're reassigning a prop, it will diverge from the passed in props if it's not bindable or not set in the parent, otherwise it will mutate the passed in props. I think that makes the most sense, given that you can't control this behavior from the outside.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: 06c5023

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14210

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14210-svelte.vercel.app/

this is an automated message

@dummdidumm dummdidumm marked this pull request as ready for review November 14, 2024 20:00
@dummdidumm dummdidumm merged commit e379319 into main Nov 14, 2024
11 checks passed
@dummdidumm dummdidumm deleted the props-binding-fix branch November 14, 2024 21:47
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: $state props are not updating in .svelte.js files when changed in component
3 participants