Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't wrap pseudo classes inside :global(...) with another :global(...) #14267

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dummdidumm
Copy link
Member

Adds a "are we inside a :global" check

fixes #14088

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 8f20ce6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14267-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14267

@dummdidumm dummdidumm merged commit 36ece1c into main Nov 12, 2024
11 checks passed
@dummdidumm dummdidumm deleted the migrate-global-fix branch November 12, 2024 13:46
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
trueadm pushed a commit that referenced this pull request Nov 13, 2024
trueadm pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested :global() not working after svelte-5 migration
3 participants