Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use strict equality for key block comparisons in runes mode #14285

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Rich-Harris
Copy link
Member

closes #14283

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: f054a92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14285

@Rich-Harris
Copy link
Member Author

preview: https://svelte-dev-git-preview-svelte-14285-svelte.vercel.app/

this is an automated message

@Leonidaz
Copy link

this doesn't seem to fix the example (simplified to console.log) in the #14283
interestingly, {$inspect(outer.inner === inner)} results in false (with a warning not to compare proxified output)

[svelte] state_proxy_equality_mismatch Reactive `$state(...)` proxies and the values they proxy have different identities. Because of this, comparisons with `===` will produce unexpected results

actually, the test in this pr also works fine (does not re-render) in the latest released version 5.1.16
and in this case, with the Symbol, the comparison {$inspect(outer.inner === inner)} is true

@Rich-Harris
Copy link
Member Author

yeah, the repro in the issue is incorrect because inner gets proxified anew each time it's assigned to outer.inner — this is correct behaviour, but made the repro unnecessarily confusing. The actual case I'm facing is this...

{#key data.current.component}
  <data.current.component state={data.current.state} />
{/key}

...and the test case in this PR simulates that with a Symbol (since only POJOs and arrays are subject to the proxification)

@Leonidaz
Copy link

🤦‍♂️ right, totally spaced out, they're deeply proxified except for anything other than simple objects or arrays.

@dummdidumm dummdidumm merged commit ac9b7de into main Nov 13, 2024
11 checks passed
@dummdidumm dummdidumm deleted the gh-14283 branch November 13, 2024 08:24
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{#key ...} blocks update when the key is unchanged
3 participants