fix: ensure dynamic call expressions correctly generate output #14345
Conversation
🦋 Changeset detectedLatest commit: 214f0cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
preview: https://svelte-dev-git-preview-svelte-14345-svelte.vercel.app/ this is an automated message |
|
| @@ -179,6 +180,7 @@ export function CallExpression(node, context) { | |||
| context.state.expression.has_call = true; | |||
| context.state.expression.has_state = true; | |||
| context.state.expression.can_inline = false; | |||
| mark_subtree_dynamic(context.path); | |||
There was a problem hiding this comment.
I think this is good, just for the sake of it, can we check wherever else we set can_inline to false to see if the subtree is actually marked dynamic?
There was a problem hiding this comment.
I added it to other places but didn't notice any differences. Which was odd, but this whole inline/dynamic system feels a bit wonky tbh.
There was a problem hiding this comment.
Yeah i think we need to restructure this a bit to keep a single source of truth (but i think it will be difficult)
Fixes #14343