Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly update dynamic member expressions #14359

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 19, 2024

Fixes #14356

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 619136c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14359-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14359

@Rich-Harris Rich-Harris changed the title fix: output template effect for svg xlink attribute fix: correctly update dynamic member expressions Nov 19, 2024
@Rich-Harris Rich-Harris merged commit 6e8267f into main Nov 19, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the ensure-dynamic-attr-works branch November 19, 2024 16:48
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5 removes href of use tag in SVG, breaking sprites
2 participants