Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always use set for private identifiers #14378

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

paoloricciuti
Copy link
Member

Closes #13965

Unless i'm missing something obvious there's no reason to not always transform PrivateIdentifiers that are also inside the class private state so no need to check for the left object to be this. JS will stop them to modify a private identifier which is not of the same class and if it is from the same class it's fine to use set to set it.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 1482e3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14378-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14378

…rmed, since the outcome of not returning immediately is the same but with extra steps
@Rich-Harris Rich-Harris merged commit 520055c into main Nov 20, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the use-set-for-private-identifiers branch November 20, 2024 20:03
This was referenced Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Incorrect Compiler Output With Private Fields
2 participants