Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow spaces around reserved words used in tags in attributes #1446

Merged
merged 1 commit into from
May 11, 2018

Conversation

Conduitry
Copy link
Member

Fixes #1445. We were already correctly handling this when things like { class } appeared as a regular HTML tag but not when it appeared in an attribute value.

@codecov-io
Copy link

codecov-io commented May 11, 2018

Codecov Report

Merging #1446 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
+ Coverage   91.09%   91.09%   +<.01%     
==========================================
  Files         122      122              
  Lines        4491     4492       +1     
  Branches     1406     1406              
==========================================
+ Hits         4091     4092       +1     
  Misses        158      158              
  Partials      242      242
Impacted Files Coverage Δ
src/parse/state/tag.ts 95.53% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd149e...0122955. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 57c0fdc into master May 11, 2018
@Rich-Harris Rich-Harris deleted the gh-1445 branch May 11, 2018 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants