Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent infinite loops when pruning CSS #14474

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix: prevent infinite loops when pruning CSS #14474

merged 3 commits into from
Nov 29, 2024

Conversation

Rich-Harris
Copy link
Member

fixes #14472, and also makes improves snippet resolution (it was only handling strings and identifiers, not literals, meaning answer={42} was interpreted as 'could be any snippet').

There might be other situations that could result in a loop, trying to think of any

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: a1330c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14474

@dummdidumm
Copy link
Member

The "collect siblings/children" logic of :has is likely prone to this, too, as soon as you come across one render tag that iterates over all snippets (because of limited static analysis) and one of those snippets also has a render tag that references all snippets

@dummdidumm dummdidumm merged commit a60e837 into main Nov 29, 2024
11 checks passed
@dummdidumm dummdidumm deleted the gh-14472 branch November 29, 2024 21:37
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5.2.11 Error: Maximum call stack size exceeded (svelte)
2 participants