Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent $state bigints incrementing and decrementing from throwing #14485

Merged
merged 11 commits into from
Dec 1, 2024

Conversation

Ocean-OS
Copy link
Contributor

@Ocean-OS Ocean-OS commented Dec 1, 2024

Closes #14484. Now, incrementing or decrementing BigInt $states will not throw an error. A test has been added for this.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 1, 2024

⚠️ No Changeset found

Latest commit: 99c354d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14485-svelte.vercel.app/

this is an automated message

Copy link
Contributor

github-actions bot commented Dec 1, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14485

@dummdidumm
Copy link
Member

Thanks! can you add a changeset?

@Rich-Harris Rich-Harris merged commit 945b625 into sveltejs:main Dec 1, 2024
10 checks passed
@Rich-Harris
Copy link
Member

thanks!

@github-actions github-actions bot mentioned this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incrementing/decrementing BigInt $states throws an error
3 participants