Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render attributes during SSR regardless of case #14492

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

This fixes part of #14479 — attributes like viewBox were failing because the name was being lowercased and then used to look up the value, creating a mismatch.

It doesn't fix the client-side error though, which happens because the contents of the <svelte:element> have an HTML template when they need an SVG one. Not yet sure what a good solution to that looks like.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 1, 2024

🦋 Changeset detected

Latest commit: ef08c12

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 1, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14492

@dummdidumm dummdidumm merged commit ef640c3 into main Dec 2, 2024
11 checks passed
@dummdidumm dummdidumm deleted the gh-14479 branch December 2, 2024 09:25
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants