fix: ensure SvelteDate cached methods have correct reactive context #14512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78df3d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Closed
trueadm
changed the title
|
preview: https://svelte-dev-git-preview-svelte-14512-svelte.vercel.app/ this is an automated message |
6 tasks
|
Is this right? Surely we want to use the reaction that was active when the instance was created, rather than an arbitrary parent effect. Opened #14525 as an alternative |
|
(In fact it looks like you reached the same conclusion here? #14506 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14506. Because the date prototype methods lazily create deriveds – that also means that it matters what the reactive context is when they're created. If they're created inside another derived then each time the derived runs, the method's deriveds will be destroyed and re-created. This is problematic because if they've already been read in another derived, then they won't be correctly shared.
Instead, we need to ensure we set the reactive context to the nearest parent effect. Deriveds created here are safe because deriveds are only added to parent effects if the derived is read in a non-reactive context.