Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect the unidirectional nature of time #14541

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Dec 4, 2024

supersedes #4531, fixes #4468. It turns out that performance.now() uses a different clock to requestAnimationFrame, or at least they behave as though that were true. You can see if yourself by doing this:

function go() {
  const then = performance.now();

  requestAnimationFrame((now) => {
    if (now < then) {
      console.error('oops! rift detected in spacetime continuum');
    }
  });
}

If you call go() enough times, you'll likely see the error, especially in Chrome.

#4531 offers one fix, but I think this one is probably more future-proof, and means that the first frame of a spring loop 'does' something which likely isn't true with the alternative.

No test because I have no idea how.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 556eec9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

preview: https://svelte-dev-git-preview-svelte-14541-svelte.vercel.app/

this is an automated message

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14541

@Rich-Harris Rich-Harris merged commit 4e77bde into main Dec 4, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the respect-entropy branch December 4, 2024 13:30
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring animation sometimes has negative start offset
2 participants