fix: respect the unidirectional nature of time #14541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #4531, fixes #4468. It turns out that
performance.now()
uses a different clock torequestAnimationFrame
, or at least they behave as though that were true. You can see if yourself by doing this:If you call
go()
enough times, you'll likely see the error, especially in Chrome.#4531 offers one fix, but I think this one is probably more future-proof, and means that the first frame of a spring loop 'does' something which likely isn't true with the alternative.
No test because I have no idea how.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint