Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat undefined and null the same for the initial input value #14562

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

dummdidumm
Copy link
Member

Fixes #14558

Any unforseen side effects that could come from this? (didn't add a test yet because I'm in a rush and want to have that question answered first)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 7db8e13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14562-svelte.vercel.app/

this is an automated message

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14562

@trueadm
Copy link
Contributor

trueadm commented Dec 4, 2024

A test case would be wonderful

@dummdidumm
Copy link
Member Author

Any drawbacks you see to this approach?

@trueadm
Copy link
Contributor

trueadm commented Dec 4, 2024

Any drawbacks you see to this approach?

Nothing stands out for me. So it's probably fine. I just thought a test case to cover this regression would be cool.

@Rich-Harris Rich-Harris merged commit 73b3cf7 into main Dec 5, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the input-value-null-undefined branch December 5, 2024 13:56
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultValue is not working in <input type=text> when the initial value is null
3 participants