Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow exports with source from script module even if no bind is present #14620

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Dec 8, 2024

Closes #14618

I updated the compiler errors test suite to be able to assert that no error is thrown (i think it can be useful in situation like this) but i can rewrite it and move the test to runtime-runes for example.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 8, 2024

🦋 Changeset detected

Latest commit: 63ebfc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 8, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14620

@dummdidumm
Copy link
Member

Move the test to the validator test suite, where you can assert that no error is thrown.

In the mid term we should move all compiler errors to the validator test suite.

@paoloricciuti
Copy link
Member Author

Move the test to the validator test suite, where you can assert that no error is thrown.

In the mid term we should move all compiler errors to the validator test suite.

Lol i think i did the same change some time ago and had to fix the same thing...i need to remember next time. Fixing now

@Rich-Harris Rich-Harris merged commit 38171f6 into main Dec 9, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the not-eport-undefined-with-source branch December 9, 2024 15:48
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export_undef when exporting from a <script module>
3 participants