Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't emit assignment warnings for bindings #14651

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

dummdidumm
Copy link
Member

Also fixes the possibility of an infinite loop due to the property access during the dev time check

fixes #14643

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Also fixes the possibility of an infinite loop due to the property access during the dev time check

fixes #14643
Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: cc9c43e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14651

@dummdidumm dummdidumm merged commit 88184cd into main Dec 10, 2024
11 checks passed
@dummdidumm dummdidumm deleted the assignment-check-fix branch December 10, 2024 13:50
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False assignment_value_stale warning
2 participants