Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update the linked playgrounds in the snippet docs #14676

Merged

Conversation

JR-G
Copy link
Contributor

@JR-G JR-G commented Dec 11, 2024

Before submitting the PR, please make sure you do the following

For #14114

I've updated the playground links to make the table a bit nicer on the eyes in dark mode:

Before After
image image

There's also a link further down the page:

Any content inside the component tags that is not a snippet declaration implicitly becomes part of the children snippet (demo):

that appears to be pointing to the wrong example.


  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 8daf0a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14676

@JR-G JR-G marked this pull request as ready for review December 11, 2024 19:55
@Conduitry
Copy link
Member

Thanks, but this is for the old svelte-5-preview site, which no longer exists. These should be edited in the file linked to by the 'edit this page' at the bottom of https://svelte.dev/docs/svelte/snippet

@Conduitry Conduitry closed this Dec 11, 2024
@Conduitry Conduitry reopened this Dec 11, 2024
@JR-G JR-G force-pushed the 14114-snippet-demo-show-lettters-in-dark-mode branch from 4866b21 to 302f694 Compare December 12, 2024 09:20
@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14676-svelte.vercel.app/

this is an automated message

@JR-G
Copy link
Contributor Author

JR-G commented Dec 12, 2024

Thanks, but this is for the old svelte-5-preview site, which no longer exists. These should be edited in the file linked to by the 'edit this page' at the bottom of https://svelte.dev/docs/svelte/snippet

@Conduitry rectified

@Rich-Harris Rich-Harris merged commit 432db95 into sveltejs:main Dec 12, 2024
10 checks passed
@Rich-Harris
Copy link
Member

Thank you! Tweaked slightly to use system colors, the bright background is jarring in dark mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants