Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve unowned derived performance #14724

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix: improve unowned derived performance #14724

merged 3 commits into from
Dec 16, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Dec 16, 2024

Fixes some of the performance issues on #14721

If we have an unowned derived that is actively in the graph, we can mark it as CLEAN. It's only if it's not in the graph can we not.

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14724

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 90e6f60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

This'll need a changeset

@trueadm trueadm closed this Dec 16, 2024
@trueadm trueadm reopened this Dec 16, 2024
@trueadm trueadm merged commit 699dc6e into main Dec 16, 2024
21 checks passed
@trueadm trueadm deleted the fix-unowned-perf branch December 16, 2024 20:05
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants