fix: compare array contents for equality mismatch detections, not the arrays themselves #14738
+84
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arrays themselves
🦋 Changeset detectedLatest commit: c0facdd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
trueadm
approved these changes
Dec 17, 2024
Leonidaz
reviewed
Dec 17, 2024
|
|
||
| if (test !== -1) { | ||
| w.state_proxy_equality_mismatch('array.indexOf(...)'); | ||
| for (let i = from_index ?? 0; i < this.length; i += 1) { |
There was a problem hiding this comment.
can this check as the others that use it be only done in DEV? Seems kind of wasteful to do in production if an item legitimately doesn't exist.
There was a problem hiding this comment.
it is only done in dev
There was a problem hiding this comment.
nice! oops, sorry, missed that this is all inside init_array_prototype_warnings 🤦♂️ which is only called in DEV
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14705, alternative to #14729
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint