fix: bump esrap, prevent malformed AST #14742
Merged
+47
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library Svelte uses to turn an AST into code, esrap, added support for TypeScript generation in Rich-Harris/esrap#13.
Unfortunately this broke a bunch of stuff, because Svelte hands
esrap
a malformed AST. Previously, this was fine — converting a type annotation to anEmptyStatement
worked fine, because empty statements would always get stripped out — but no longer.The solution is to strip type annotations (and type parameters, and return types, and things like
node.accessibility
from nodes so that they are ignored altogether byesrap
. There may be other fields that also need to be removed — not totally sure — but I think I got all the ones that matter (e.g. they're not inside interface declarations which are removed altogether).Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint