Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump esrap, prevent malformed AST #14742

Merged
merged 8 commits into from
Dec 18, 2024
Merged

fix: bump esrap, prevent malformed AST #14742

merged 8 commits into from
Dec 18, 2024

Conversation

Rich-Harris
Copy link
Member

The library Svelte uses to turn an AST into code, esrap, added support for TypeScript generation in Rich-Harris/esrap#13.

Unfortunately this broke a bunch of stuff, because Svelte hands esrap a malformed AST. Previously, this was fine — converting a type annotation to an EmptyStatement worked fine, because empty statements would always get stripped out — but no longer.

The solution is to strip type annotations (and type parameters, and return types, and things like node.accessibility from nodes so that they are ignored altogether by esrap. There may be other fields that also need to be removed — not totally sure — but I think I got all the ones that matter (e.g. they're not inside interface declarations which are removed altogether).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 3e5e7c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14742

@Rich-Harris Rich-Harris merged commit c033dae into main Dec 18, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the bump-esrap branch December 18, 2024 01:20
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant