Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure $inspect.trace indicated dirty traced deps correctly #14801

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Dec 21, 2024

Should fix the bug where a traced dependency that was mutated as part of the same effect incorrectly gets marked as not changed. I haven't had time to extensively test it though so leaving as a draft.

Fixes #14794

Copy link

changeset-bot bot commented Dec 21, 2024

⚠️ No Changeset found

Latest commit: cd2fd4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14801

@trueadm trueadm marked this pull request as draft December 21, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$inspect.trace() is missing information or Svelte is running effects unnecessarily
1 participant