-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow const tag inside svelte:boundary
#14993
Conversation
🦋 Changeset detectedLatest commit: c0989f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-svelte-14993-svelte.vercel.app/ this is an automated message |
|
db4c5e0
to
d93af12
Compare
I've added the test for when #14999 will be merged (for the moment it's failing cause it requires that PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update and docs for this change?
Uh right let me check |
Closes #14987
I don't see why we shouldn't allow
const
here but if you have any reason we can close. I left a TODO in the text because i noticed that reactivity is lost when thefailed
snippet is rendered but that's true in general (gonna open an issue about it in a sec).Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint