Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow const tag inside svelte:boundary #14993

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

paoloricciuti
Copy link
Member

Closes #14987

I don't see why we shouldn't allow const here but if you have any reason we can close. I left a TODO in the text because i noticed that reactivity is lost when the failed snippet is rendered but that's true in general (gonna open an issue about it in a sec).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: c0989f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14993-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14993

@paoloricciuti paoloricciuti force-pushed the const-tag-svelte-boundary branch from db4c5e0 to d93af12 Compare January 13, 2025 21:09
@paoloricciuti
Copy link
Member Author

I've added the test for when #14999 will be merged (for the moment it's failing cause it requires that PR)

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update and docs for this change?

@paoloricciuti
Copy link
Member Author

Do we need to update and docs for this change?

Uh right let me check

@paoloricciuti paoloricciuti merged commit a129592 into main Jan 14, 2025
11 checks passed
@paoloricciuti paoloricciuti deleted the const-tag-svelte-boundary branch January 14, 2025 00:36
@github-actions github-actions bot mentioned this pull request Jan 14, 2025
dummdidumm added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for {@const} Inside <svelte:boundary>
3 participants