feat(elements): Expose ClassValue #15035
Merged
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1fd40f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
preview: https://svelte-dev-git-preview-svelte-15035-svelte.vercel.app/ this is an automated message |
|
packages/svelte/elements.d.ts
Outdated
| @@ -2059,3 +2059,5 @@ export interface SvelteHTMLElements { | |||
|
|
|||
| [name: string]: { [name: string]: any }; | |||
| } | |||
|
|
|||
| export type ClassValue = import('clsx').ClassArray | import('clsx').ClassDictionary; | |||
There was a problem hiding this comment.
Since we are exporting this I think it would be easier to also include string here right? So whoever is using it can just use this without adding string by itself
PuruVJ
commented
Jan 16, 2025
packages/svelte/elements.d.ts
Outdated
| @@ -2059,3 +2059,5 @@ export interface SvelteHTMLElements { | |||
|
|
|||
| [name: string]: { [name: string]: any }; | |||
| } | |||
|
|
|||
| export type ClassValue = import('clsx').ClassArray | import('clsx').ClassDictionary; | |||
There was a problem hiding this comment.
Originally I wanted to export import('clsx').ClassValue itself but considering this file only uses the two ClassDictionary and ClassArray types, I kept those intact
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
paoloricciuti
approved these changes
Jan 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15033
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint