Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add templating to {#snippets} #15172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sacrosanctic
Copy link
Contributor

closes #14020

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: 343f3d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

Could you update your branch? Seems like your branch is very outdated.

@sacrosanctic
Copy link
Contributor Author

Could you update your branch? Seems like your branch is very outdated.

fixed

@Rich-Harris
Copy link
Member

Huh? This is already present, as noted in #14020 (comment). The equivalent of the {#if ....} example you called out is this:

image

This seems very duplicative and unnecessary, what am I missing?

@sacrosanctic
Copy link
Contributor Author

The equivalent of the {#if ....} example you called out is this:

This shows how a snippet is created but not how snippet is passed to a component.

image

This demonstrates the 3 ways can that be done. Visually and in compact form. Useful like a cheatsheet.

what am I missing?

I guess it comes down to whether you see the docsite as a howto or a reference.

image

https://youtu.be/RwBolXX9Pis?si=iBOFarAHT1jywS5K&t=459

I'm ok either way and am happy to close the respective issues and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Snippet docs doesn't mention direct/explicit method
3 participants