-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow objects/arrays for style attribute #15311
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: e6717ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I think allowing multiple casings is actually a mistake, as it would remove what would probably be the biggest value added by this feature, which would be intellisense |
I like this, but I'm not sure why arrays would be allowed in the |
@Thiagolino8 : personally I like the idea of having the choice between snake_case or camelCase. @Ocean-OS : like for classes, arrays allow to simply extends a value received from props, who can be a string or an object... |
style
attribute to accept objects/arrays, in a way similar to feat: allow objects/arrays for class attribute #14714 (I based this PR on this work)style
can receive strings/arrays/objects to build the style CSS text :All these lines are equivalent :
Notes :
Will fix it according to the decision of this issue...
For
class
there a call tomark_subtree_dynamic(context.path)
but I don't know if this is required here.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint