Skip to content

fix: never deduplicate expressions in templates #15451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix: never deduplicate expressions in templates #15451

merged 1 commit into from
Mar 5, 2025

Conversation

Rich-Harris
Copy link
Member

Fixes #15096. A shame to lose this optimisation, but it doesn't make a difference to the vast majority of apps, and correctness comes first.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 5, 2025

🦋 Changeset detected

Latest commit: 0d4e966

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15451

@Rich-Harris Rich-Harris merged commit 76f5ecf into main Mar 5, 2025
10 checks passed
@Rich-Harris Rich-Harris deleted the gh-15096 branch March 5, 2025 16:26
@Rich-Harris Rich-Harris mentioned this pull request Mar 5, 2025
6 tasks
@github-actions github-actions bot mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using expression containing Math.random() more than once wrongly assumes all instances should have same result
2 participants