Quote name of attribute to nested components #1555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #887 by quoting name of attributes if those are invalid JS identifiers when passing data to nested components, so something like this would compile and run successfully.
Please note that this does not add support for acessing these attributes directly on the component code, but only adds support for passing that data to the nested component. I think a valid idea here is to let the user use a computed property on the nested component returning the whole state (like
state
, maybe?) to access the data on template tags using{ state["b-c"] }
, for example.I'll add tests tonight, by the way, so this is still a WIP. But feel free to test and comment about the idea. =)