fix: allow accessing snippet in script tag #15789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15786
Initially i thought of just changing
const
withvar
and effectively the error is gone...however the runtime behaviour is not the same as the value will be undefined before initialisation.So what i did is revert back to function declaration and then invoking
$.prevent_snippet_stringification
on the function declaration discarding the return value (i don't like this bit but i couldn't think of a way around)...it still works because we are still changing thetoString
of the function.The small bit of inconsistency is that if you invoke
toString
in the script tag it will not error out but i would say is probably fine since the error is meant for the template rather than the script tag.Is there a better solution to this?
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint